[CHORE]: Fix jupyter deps issue - #5694
Merged
Merged
Conversation
… rather than the much larger 'jupyterlab'
camdecoster
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
There's a CI failure on
maincaused by the Jupyter Python dependencies used to build the Jupyterlab extension.The ultimate failure seems to be caused by a recent change in
jupyterlab-builderwhich doesn't properly account for the||specifier inpackage.jsondeps.However, the reason we're hitting that code path in the first place is due to this warning, and the special handling added as a result:
Description of change
"@jupyter/builder": "^1.2.2",rather than"@jupyterlab/builder": "^4.3.6 || ^3.6.8",in package.jsonjupyter-builder buildrather thanjupyter labextension buildjupyter-builderrather thanjupyterin the[dev_build]extra in pyproject.tomljupyter-builderis required to build the extension, and it's over an order of magnitude smaller thanjupyterlabjupyterto the[dev_optional]extra since it's still required for some of the testspackage-lock.jsonanduv.lockTesting strategy
Make sure the extension builds without error.
Then, verify that the built extension works in Jupyter:
uv pip install -e .jupyter notebookMake sure both figures render in the notebook.
Guidelines